This repository was archived by the owner on Jul 6, 2026. It is now read-only.
Conversation
pjcollins
reviewed
Nov 7, 2019
pjcollins
reviewed
Nov 7, 2019
pjcollins
approved these changes
Nov 7, 2019
pjcollins
left a comment
pjcollins
left a comment
Member
There was a problem hiding this comment.
LGTM, though there is one failure on the old pipeline that I am assuming is transient?
Contributor
Author
|
Yeah, it's a sporadic native crash: |
Member
|
👍. I did just realize we could clean this up a bit more by removing the stage aspect, but it's fine either way. |
Contributor
Author
|
Cool, removed the stages to simplify it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port existing Windows and Mac Azure pipelines to a single YAML based pipeline.
New pipeline:
https://devdiv.visualstudio.com/DevDiv/_build?definitionId=12262&_a=summary